Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: demo restoreFocus with controlled menu [ DO NOT MERGE! ] #661

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Sep 13, 2024

FOR DEMO PURPOSES ONLY - DO NOT MERGE ❗

Description

Adds a "Controlled + Managed Focus" Story to demo the restoreFocus behavior featured in #659 with a controlled menu.

@coveralls
Copy link

Coverage Status

coverage: 95.714% (-0.002%) from 95.716%
when pulling f43e450 on ze-flo/menu-restore-focus
into ec77a9d on main.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like moving this to a "Controlled trigger focus" story (using all of the standard code constructs) under the "[patterns]" section would be a valuable addition to #659 so we can easily track the behavior going forward. Compare with many of the other "[pattern]" stories – many/all of the arg controls can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants